[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 22 10:52:51 PDT 2020


ldionne added a comment.

I personally don't think the note is useful. What we're trying to tell the user is "don't use X after you've moved out of X" -- whether the move actually has an effect or not is not useful information. To me, adding `; move of a 'const' argument has no effect` just makes things less clear -- are you trying to tell me I shouldn't use-after-move, or something else more subtle?

Just my .02


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74692/new/

https://reviews.llvm.org/D74692





More information about the cfe-commits mailing list