[PATCH] D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type'

[Whisperity via Phabricator via cfe-commits]

whisperity marked 2 inline comments as done.
whisperity added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/experimental/CppcoreguidelinesAvoidAdjacentParametersOfTheSameTypeCheck.cpp:747
     OS << "...";
-  } else
+  } else {
     // There are things like "GCC Vector type" and such that who knows how
----------------
'chute, I hate merge conflicts...


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type.rst:113-120
+    .. warning::
+        Turning the modelling of implicit conversion sequences on
+        relaxes the constraints for "type convertibility" significantly,
+        however, it also applies a generous performance hit on the check's cost.
+        The check will have to explore a **polynomially more** possibilities:
+        O(n\ :sup:`2`\ ) instead of O(n) for each function's ``n`` parameters.
+        The emitted diagnostics will also be more verbose, which might take more
----------------
This change to check the "left half" of a full graph moved to the main checker patch D69560 and there is no significant (few seconds, on large projects like LLVM) time difference between the modes at all even on large projects... so this fearmongering text should be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75041/new/

https://reviews.llvm.org/D75041