[PATCH] D78563: [AIX] Port power alignment rules to clang

Jason Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 21 14:39:14 PDT 2020


jasonliu added inline comments.


================
Comment at: clang/test/Layout/aix-double-struct-member.cpp:136
+// CHECK-NEXT:            |  nvsize=12, nvalign=4]
+}; // namespace test4
----------------
1. I think we also want to test empty base class with a derived class contains double as first. And also a non-empty base class with derived contains double as first to show that it has effect on basic inheritance as well.
2. We need one more test for seeing how pack align interact with AIX alignment. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78563/new/

https://reviews.llvm.org/D78563





More information about the cfe-commits mailing list