[PATCH] D78501: Add a facility to get system cache directory and use it in clangd
Vojtěch Štěpančík via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 20 09:10:38 PDT 2020
VojtechStep created this revision.
VojtechStep added reviewers: sammccall, chandlerc, Bigcheese.
VojtechStep added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, usaxena95, ormris, kadircet, arphaman, dexonsmith, jkorous, MaskRay, ilya-biryukov, hiraditya.
Herald added a project: clang.
This patch adds a function that is similar to `llvm::sys::path::home_directory`, but provides access to the system cache directory.
For Windows, that is %LOCALAPPDATA%, and applications should put their files under %LOCALAPPDATA%\Organization\Product\.
For *nixes, it adheres to the XDG Base Directory Specification, so it first looks at the XDG_CACHE_HOME environment variable and falls back to ~/.cache/.
Subsequently, the Clangd Index storage leverages this new API to put index files somewhere else than the users home directory.
Previous discussion is here <https://github.com/clangd/clangd/issues/341>
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D78501
Files:
clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp
llvm/include/llvm/Support/Path.h
llvm/lib/Support/Unix/Path.inc
llvm/lib/Support/Windows/Path.inc
llvm/unittests/Support/Path.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78501.258764.patch
Type: text/x-patch
Size: 7262 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200420/5124b035/attachment.bin>
More information about the cfe-commits
mailing list