[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

[George Rimar via Phabricator via cfe-commits]

grimar added a comment.

In D78024#1989287 <https://reviews.llvm.org/D78024#1989287>, @probinson wrote:

> I'm just reading this review for the first time, and my thought was, why is this interacting with implicit-check-not?


It was interacting (this patch was committed and fixed the issue), because the code used the logic to add an EOF pattern
for "any trailing --implicit-check-not/CHECK-DAG/-NOTs" before the error about "no check strings found with prefix" was reported.
I.e. this logic suppressed the error, because `CheckStrings` was not empty anymore:

    if (CheckStrings->empty()) {
      errs() << "error: no check strings found with prefix"
  ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78024/new/

https://reviews.llvm.org/D78024