[PATCH] D76932: [AIX] emit .extern and .weak directive linkage
Hubert Tong via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Apr 19 17:05:19 PDT 2020
hubert.reinterpretcast added inline comments.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1509
+
+ MCSymbol *Name = getSymbol(&F);
+ if (TM.getTargetTriple().isOSBinFormatXCOFF() && !F.isIntrinsic()) {
----------------
Add a comment that this gives us the function descriptor symbol.
================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2146
}
}
----------------
Replicate the
```
llvm_unreachable("Unknown linkage type!");
```
here before falling off the end of a function that does not return `void`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76932/new/
https://reviews.llvm.org/D76932
More information about the cfe-commits
mailing list