[PATCH] D77221: [AVR] Rework MCU family detection to support more AVR MCUs

[Dylan McKay via Phabricator via cfe-commits]

dylanmckay requested changes to this revision.
dylanmckay added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/lib/Basic/Targets/AVR.h:21
 
+#include "llvm/Support/AVRTargetParser.h"
+
----------------
Order this `#include` alphabetically with the ones above it


================
Comment at: llvm/include/llvm/Support/AVRTargetParser.h:9
+//
+// This file implements a target parser to recognise AVR CPUs
+//
----------------
Add another sentence or two to this documentation, as this will be a new public-facing API that all frontends can use.


================
Comment at: llvm/lib/Support/AVRTargetParser.cpp:20
+// This list should be kept up-to-date with AVRDevices.td in LLVM.
+static constexpr AVR::MCUInfo AVRMcus[] = {
+    {"avr1", "at90s1200", "__AVR_AT90S1200__"},
----------------
Add a comment like `FIXME: At some point, this list should removed and the logic directly driven from the definitions in `AVRDevices.td`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77221/new/

https://reviews.llvm.org/D77221