[PATCH] D78366: [Preamble] Allow recursive inclusion of header-guarded mainfile.
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Apr 18 02:08:23 PDT 2020
kadircet added inline comments.
================
Comment at: clang/lib/Lex/PPDirectives.cpp:2070
+ diag::err_pp_including_mainfile_in_preamble);
+ return {ImportAction::None};
+ }
----------------
Instead of returning here I think we should set the Action to `Skip`. So that relevant callbacks (`InclusionDirective` and `FileSkipped`) is invoked. (maybe have a test for that too?)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78366/new/
https://reviews.llvm.org/D78366
More information about the cfe-commits
mailing list