[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

Fri Apr 17 15:11:04 PDT 2020

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: clang/utils/TableGen/SveEmitter.cpp:1035
+  OS << "#define svcvtxnt_f32_x     svcvtxnt_f32_m\n";
+  OS << "#define svcvtxnt_f32_f64_x svcvtxnt_f32_f64_m\n\n";
+
----------------
sdesmalen wrote:
> efriedma wrote:
> > Not worth implementing these separately?  I guess I can see why it wouldn't be profitable.
> We currently don't really optimise the _x (MergeAny) case yet for other intrinsics, so addressing this seems more trouble than it's worth, specifically because the merging with `undef` for only the top/odd lanes would not be trivial to represent. 
Okay.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78239/new/

https://reviews.llvm.org/D78239