[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

Thu Apr 16 20:01:45 PDT 2020

jsji added inline comments.

================
Comment at: clang/lib/Basic/Targets/PPC.cpp:243
+  bool Passed = CheckVSXSubfeature("+power8-vector", "-mpower8-vector");
+  Passed |= CheckVSXSubfeature("+direct-move", "-mdirect-move");
+  Passed |= CheckVSXSubfeature("+float128", "-mfloat128");
----------------
Looks like this is will cause behavior change.. And NOT NFC at all..

Before refactor, we will return false when *ANY* of the subfeature is ON.
After refactor, we will only return false, when *ALL* of the subfeature are ON, Passed will be set to true when any of subfeature are off .

Can you please double check?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78308/new/

https://reviews.llvm.org/D78308