[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

Thu Apr 16 16:10:47 PDT 2020

efriedma added a comment.

I think the predicate type is something we should fix.   Even if it's not causing problems now, it seems like the sort of thing that will bite us later.

It doesn't necessarily need to block this patch, I guess, but it at least needs a good comment in EmitAArch64SVEBuiltinExpr explaining what's happening.

================
Comment at: clang/utils/TableGen/SveEmitter.cpp:1035
+  OS << "#define svcvtxnt_f32_x     svcvtxnt_f32_m\n";
+  OS << "#define svcvtxnt_f32_f64_x svcvtxnt_f32_f64_m\n\n";
+
----------------
Not worth implementing these separately?  I guess I can see why it wouldn't be profitable.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78239/new/

https://reviews.llvm.org/D78239