[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

Thu Apr 16 10:35:25 PDT 2020

MaskRay added a comment.

> btw, do you know why FileCheck seems intentionally allows the case when --check-prefixes=KNOWN,UNKNOWN? I've mentioned in the description of D78110 <https://reviews.llvm.org/D78110> that there are about 1000 tests that have this. but is it a feature or a something that we might want to fix?

Confirmed. Both `FileCheck --check-prefix=KNOWN --check-prefix=UNKNOWN` and `FileCheck --check-prefixes=KNOWN,UNKNOWN` are allowed. This looks to me another bug-prone area which we should clean up.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78024/new/

https://reviews.llvm.org/D78024