[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

Wed Apr 15 13:13:40 PDT 2020

mibintc added a comment.

In D76384#1984584 <https://reviews.llvm.org/D76384#1984584>, @rjmccall wrote:

> In D76384#1984498 <https://reviews.llvm.org/D76384#1984498>, @mibintc wrote:
>
> > Responding to @rjmccall 's review.  John, after this is approved I want to proceed with pragma float_control as proposed in D72841 <https://reviews.llvm.org/D72841>. Can you recommend an approach, do you think I will need to do it incrementally?
>
>
> I think the basic technical approach from that patch seems reasonable.  It's not my goal to hold up your work to pursue other technical goals; we took this detour just to minimize the memory impact of your work.

Thanks for all. I'm sure my work will be easier in the long run to have this well scrutinized. And I learned a lot. And I endorse not being wasteful of memory.

> I *would* like an NFC patch first that renames `FPFeatures` to something like `CurFPFeatures` in order to more clearly distinguish it from `FPOptions` in Sema code, though.  That should be very quick.

OK. I think this means I can commit now and change the identifier spelling in a future standalone patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76384/new/

https://reviews.llvm.org/D76384