[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

Minor fixes, then LGTM.



================
Comment at: clang/lib/AST/ASTImporter.cpp:6807
+      importChecked(Err, ToComputationLHSType),
+      importChecked(Err, ToComputationResultType));
 }
----------------
Oh, these two calls need to use `E->getFPFeatures(Importer.getFromContext())`, since that's the context that the node was built in.


================
Comment at: clang/lib/CodeGen/CGObjC.cpp:1497
+      OK_Ordinary, SourceLocation(),
+      FPOptions::defaultWithoutTrailingStorage(getContext()));
+  EmitStmt(assign);
----------------
Missed this one.


================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2935
+        C, &IVRefExpr, &UBRefExpr, BO_LE, C.BoolTy, VK_RValue, OK_Ordinary,
+        S.getBeginLoc(), FPOptions::defaultWithoutTrailingStorage(C));
     // Increment for loop counter.
----------------
Missed this one.


================
Comment at: clang/lib/Sema/SemaOverload.cpp:13784
+                                        Args, ResultTy, VK, RLoc,
+                                        FPOptions(Context.getLangOpts()));
         if (CheckCallReturnType(FnDecl->getReturnType(), LLoc, TheCall, FnDecl))
----------------
This should use FPFeatures, I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76384/new/

https://reviews.llvm.org/D76384