[PATCH] D77866: [analyzer][CallAndMessage] Add checker options for each bug category

[Gabor Marton via Phabricator via cfe-commits]

martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.

Looks good to me!



================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:194
+               const ProgramPointTag *Tag = nullptr) {
+    // Say this 3 times fast.
+    State = State ? State : getState();
----------------
I like joke :D But there are people who may not, so, the code would be more pro without it. 


================
Comment at: clang/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:66
+  // convert these to actual checkers.
+  enum CheckKind {
+    CK_FunctionPointer,
----------------
So, we are not going to have subcheckers, rather options, okay. Perhaps the comment would be more appropriate to be in `Checkers.td`? (If we can put comments there.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77866/new/

https://reviews.llvm.org/D77866