[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

Wed Apr 15 03:47:23 PDT 2020

kbobyrev marked an inline comment as done.
kbobyrev added inline comments.

================
Comment at: clang-tools-extra/clangd/CMakeLists.txt:194
+
+  add_definitions(-DGOOGLE_PROTOBUF_NO_RTTI=1)
+  include_directories(${Protobuf_INCLUDE_DIRS})
----------------
sammccall wrote:
> these global side-effects are pretty scary, can we limit them somehow?
I'll be using `target_compile_definitions()` manually then. Not sure if it's much better (since users would have to manually add those defines), maybe if there are more protos in the future it'd be better to add function for setting up the target which will be linked against generated protobufs.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77794/new/

https://reviews.llvm.org/D77794