[PATCH] D78181: [clangd] Fix a crash for accessing a null field decl returned by findExplicitReferences.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 15 01:02:54 PDT 2020


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/FindTarget.cpp:702
           continue;
+        if (!D.getField())
+          continue;
----------------
thanks for fixing this !

But I suppose we should rather return a result with empty `TargetDecl` as this is what API promises:

`  /// For dependent and unresolved references, Targets can also be empty.`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78181/new/

https://reviews.llvm.org/D78181





More information about the cfe-commits mailing list