[PATCH] D78125: [AVR] Use the correct address space for non-prototyped function calls

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 14 17:26:39 PDT 2020


MaskRay added a comment.

> This fix is necessary to let Clang compile compiler-rt for AVR.

This suggests that some compiler-rt declarations do not follow the best practice... What are they?



================
Comment at: clang/test/CodeGen/address-space-avr.c:3
+
+// CHECK: define void @bar() addrspace(1)
+// CHECK: call addrspace(1) void bitcast (void (...) addrspace(1)* @foo to void (i16) addrspace(1)*)(i16 3)
----------------
Add a comment what happens here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78125/new/

https://reviews.llvm.org/D78125





More information about the cfe-commits mailing list