[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 14 14:39:21 PDT 2020
rjmccall added inline comments.
================
Comment at: clang/lib/CodeGen/CGExprAgg.cpp:688
+
+ op = castE;
}
----------------
ekatz wrote:
> rjmccall wrote:
> > I liked the structure of the old code better, in case we want to look through other kinds of expressions. Please just add `op = castE->getSubExpr()` before the `continue`.
> I see your point. I'll change that.
> Though I must say that the old structure is a little strange with the `return nullptr` in the end of the loop...
Oh, you know, there's also an `IgnoreParenNoopCasts` that we could just use instead of this loop if we're willing to ignore other possible expressions we might want to look through.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78098/new/
https://reviews.llvm.org/D78098
More information about the cfe-commits
mailing list