[PATCH] D78148: [CodeGen] make isTriviallyRecursive handle more trivial recursion

George Burgess IV via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 14 14:39:19 PDT 2020


george.burgess.iv abandoned this revision.
george.burgess.iv added a comment.

Nothing in the real world :)

I was writing test-cases for a soon-to-be-in-your-inbox patch, and initially wrote `memcpy` recursion in terms of `memcpy`, rather than `__builtin_memcpy`. Wasn't sure if this was an oversight, or intended. The comments around the use of this through `isTriviallyRecursive` said "a[n externally-available] function that calls itself is clearly not equivalent to the real implementation." Since this behavior is intentional, I'll see if I can make that commentary a bit more clear instead.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78148/new/

https://reviews.llvm.org/D78148





More information about the cfe-commits mailing list