[clang] 91c8c74 - [CodeGen] clarify a comment; NFC

George Burgess IV via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 14 14:33:20 PDT 2020


Author: George Burgess IV
Date: 2020-04-14T14:33:01-07:00
New Revision: 91c8c74180ced4b82da02f2544f3978f72003d37

URL: https://github.com/llvm/llvm-project/commit/91c8c74180ced4b82da02f2544f3978f72003d37
DIFF: https://github.com/llvm/llvm-project/commit/91c8c74180ced4b82da02f2544f3978f72003d37.diff

LOG: [CodeGen] clarify a comment; NFC

Prompted by discussion on https://reviews.llvm.org/D78148.

Added: 
    

Modified: 
    clang/lib/CodeGen/CodeGenModule.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp
index 0f56dcb3e26c..39aa5c1c512f 100644
--- a/clang/lib/CodeGen/CodeGenModule.cpp
+++ b/clang/lib/CodeGen/CodeGenModule.cpp
@@ -2796,8 +2796,8 @@ bool CodeGenModule::shouldEmitFunction(GlobalDecl GD) {
 
   // PR9614. Avoid cases where the source code is lying to us. An available
   // externally function should have an equivalent function somewhere else,
-  // but a function that calls itself is clearly not equivalent to the real
-  // implementation.
+  // but a function that calls itself through asm label/`__builtin_` trickery is
+  // clearly not equivalent to the real implementation.
   // This happens in glibc's btowc and in some configure checks.
   return !isTriviallyRecursive(F);
 }


        


More information about the cfe-commits mailing list