[PATCH] D78027: [TimeProfiler] Emit real process ID and thread names

Tue Apr 14 14:05:19 PDT 2020

MaskRay added inline comments.

================
Comment at: llvm/lib/Support/TimeProfiler.cpp:249
+
+    for (const auto &TTP : ThreadTimeTraceProfilerInstances) {
+      writeMetadataEvent("thread_name", TTP->Tid, TTP->ThreadName);
----------------
MaskRay wrote:
> broadwaylamb wrote:
> > MaskRay wrote:
> > > Delete `{}` for simple statements. In LLVM code, such `{}` is not common.
> > The code above uses `{}`.
> > 
> > According to http://llvm.org/docs/CodingStandards.html:
> > 
> > >If you are extending, enhancing, or bug fixing already implemented code, use the style that is already being used so that the source is uniform and easy to follow.
> They were added without enough scrutiny. There are many other simple statements in this file not surrounded by `{}`
See D78153

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78027/new/

https://reviews.llvm.org/D78027