[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 14 14:05:09 PDT 2020


ABataev added inline comments.


================
Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784
+/// This represents the '#pragma omp tile' loop transformation directive.
+class OMPTileDirective final
+    : public OMPLoopDirective,
+      private llvm::TrailingObjects<OMPTileDirective, OMPClause *, Stmt *> {
----------------
Not sure that this is a good idea to treat this directive as the executable directive. To me, it looks like kind of `AttributedStmt`. Maybe better to introduce some kind of a new base node for this and similar constructs, which does not own the loop but is its kind of attribute-like entity?
Also, can we have something like:
```
#pragma omp simd
#pragma omp tile ...
for(...) ;
```
Thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76342/new/

https://reviews.llvm.org/D76342





More information about the cfe-commits mailing list