[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

Ehud Katz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 14 14:05:03 PDT 2020


ekatz marked an inline comment as done.
ekatz added inline comments.


================
Comment at: clang/lib/CodeGen/CGExprAgg.cpp:688
+
+    op = castE;
   }
----------------
rjmccall wrote:
> I liked the structure of the old code better, in case we want to look through other kinds of expressions.  Please just add `op = castE->getSubExpr()` before the `continue`.
I see your point. I'll change that.
Though I must say that the old structure is a little strange with the `return nullptr` in the end of the loop...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78098/new/

https://reviews.llvm.org/D78098





More information about the cfe-commits mailing list