[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

[Sam McCall via Phabricator via cfe-commits]

sammccall added subscribers: adamcz, rsmith.
sammccall added a comment.

Sorry to go back and forth on this, but I'm not sure whether these diagnostics are actually spam to be suppressed. I think @adamcz mentioned these today as reasonable diagnostics we're enabling.

@rsmith do you have an opinion here?



================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:15006
   if (VD->isInvalidDecl()) return;
+  if (VD->getInit() && VD->getInit()->containsErrors())
+    return;
----------------
This deserves a comment, like "if initializing the variable failed, don't also diagnose problems with the desctructor, they're likely related".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78100/new/

https://reviews.llvm.org/D78100