[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidNonConstGlobalVariablesCheck.cpp:50
+    // variables in a function.
+    if (!Variable->isLocalVarDecl()) {
+      diag(Variable->getLocation(), "variable %0 is non-const and globally "
----------------
aaron.ballman wrote:
> I think this should be handled in the matcher rather than here. I'd add a local matcher for `isLocalVarDecl()` and add it to the `unless()` matcher. WDYT?
You should be able to remove this change now.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-avoid-non-const-global-variables.cpp:234-236
+    static int staticNonConstLoopVariable = 42;
     int nonConstLoopVariable = 42;
+    nonConstInt = nonConstLoopVariable + i + staticNonConstLoopVariable;
----------------
vingeldal wrote:
> aaron.ballman wrote:
> > I would like this example moved out of the section suggesting this is a false positive.
> I don't follow I thought you said this was a false positive and that's why I'm now making the check not catch this piece of code?
I think I just misread the comment as the opposite (false negatives), sorry for the noise!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77461/new/

https://reviews.llvm.org/D77461