[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables
Kim Viggedal via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 14 08:00:08 PDT 2020
vingeldal added inline comments.
================
Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-avoid-non-const-global-variables.cpp:234-236
+ static int staticNonConstLoopVariable = 42;
int nonConstLoopVariable = 42;
+ nonConstInt = nonConstLoopVariable + i + staticNonConstLoopVariable;
----------------
aaron.ballman wrote:
> I would like this example moved out of the section suggesting this is a false positive.
I don't follow I thought you said this was a false positive and that's why I'm now making the check not catch this piece of code?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77461/new/
https://reviews.llvm.org/D77461
More information about the cfe-commits
mailing list