[PATCH] D77875: [ARM] Armv8.6-a Matrix Mul cmd line support

Luke Geeson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 14 08:00:06 PDT 2020


LukeGeeson added a comment.

In D77875#1979980 <https://reviews.llvm.org/D77875#1979980>, @DavidSpickett wrote:

> > Note: +f32mm and +f64mm are optional and so have to be enabled by default
>
> I think I know what you mean, but "and so are not enabled by default" would be clearer.
>
> Also to double check, does f64mm imply f32mm? (not sure if there's an updated ARMARM yet that would tell me that)


Since these options can be enabled independently pre-8.6a in general the answer is no. I'll add a comment noting why we only only imply f32mm in AArch64.cpp

In D77875#1980488 <https://reviews.llvm.org/D77875#1980488>, @DavidSpickett wrote:

> Or in other words, does amrv8.6-a+sve imply +f32mm *and* +f64mm?


Also no here, as an example the xml has different checks for fmmla https://developer.arm.com/docs/ddi0596/latest/a64-sve-instructions-alphabetic-order/fmmla-floating-point-matrix-multiply-accumulate


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77875/new/

https://reviews.llvm.org/D77875





More information about the cfe-commits mailing list