[libclc] acf0790 - libclc: Use echo rather than true for try_compile

Jan Vesely via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 14 07:04:18 PDT 2020


Author: Daniel Stone
Date: 2020-04-14T10:03:27-04:00
New Revision: acf079006e6dbdd23300e9289cc8d8197aab5fb5

URL: https://github.com/llvm/llvm-project/commit/acf079006e6dbdd23300e9289cc8d8197aab5fb5
DIFF: https://github.com/llvm/llvm-project/commit/acf079006e6dbdd23300e9289cc8d8197aab5fb5.diff

LOG: libclc: Use echo rather than true for try_compile

When providing a fake compiler, libclc currently uses 'true' which does
not exist on Windows. Use echo instead as the no-op.

reviewer: jvesely
Differential Revision: https://reviews.llvm.org/D77163

Added: 
    

Modified: 
    libclc/cmake/CMakeTestCLCCompiler.cmake
    libclc/cmake/CMakeTestLLAsmCompiler.cmake

Removed: 
    


################################################################################
diff  --git a/libclc/cmake/CMakeTestCLCCompiler.cmake b/libclc/cmake/CMakeTestCLCCompiler.cmake
index fae660fbcadc..869fcc3d01ab 100644
--- a/libclc/cmake/CMakeTestCLCCompiler.cmake
+++ b/libclc/cmake/CMakeTestCLCCompiler.cmake
@@ -24,7 +24,7 @@ if(NOT CMAKE_CLC_COMPILER_WORKS)
   try_compile(CMAKE_CLC_COMPILER_WORKS ${CMAKE_BINARY_DIR}
     ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeTmp/testCLCCompiler.cl
     # We never generate executable so bypass the link step
-    CMAKE_FLAGS -DCMAKE_CLC_LINK_EXECUTABLE='true'
+    CMAKE_FLAGS -DCMAKE_CLC_LINK_EXECUTABLE='echo'
     OUTPUT_VARIABLE __CMAKE_CLC_COMPILER_OUTPUT)
   # Move result from cache to normal variable.
   set(CMAKE_CLC_COMPILER_WORKS ${CMAKE_CLC_COMPILER_WORKS})

diff  --git a/libclc/cmake/CMakeTestLLAsmCompiler.cmake b/libclc/cmake/CMakeTestLLAsmCompiler.cmake
index 1a87457c2cde..35948ee07a94 100644
--- a/libclc/cmake/CMakeTestLLAsmCompiler.cmake
+++ b/libclc/cmake/CMakeTestLLAsmCompiler.cmake
@@ -24,7 +24,7 @@ if(NOT CMAKE_LLAsm_COMPILER_WORKS)
   try_compile(CMAKE_LLAsm_COMPILER_WORKS ${CMAKE_BINARY_DIR}
     ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeTmp/testLLAsmCompiler.ll
     # We never generate executable so bypass the link step
-    CMAKE_FLAGS -DCMAKE_LLAsm_LINK_EXECUTABLE='true'
+    CMAKE_FLAGS -DCMAKE_LLAsm_LINK_EXECUTABLE='echo'
     OUTPUT_VARIABLE __CMAKE_LLAsm_COMPILER_OUTPUT)
   # Move result from cache to normal variable.
   set(CMAKE_LLAsm_COMPILER_WORKS ${CMAKE_LLAsm_COMPILER_WORKS})


        


More information about the cfe-commits mailing list