[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 14 06:55:08 PDT 2020


sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/index/remote/CMakeLists.txt:19
+add_library(gRPCProtos ${Index_proto_source} ${Index_grpc_header} ${Index_grpc_source} ${Index_grpc_header})
+target_link_libraries(gRPCProtos gRPC::grpc++ protobuf::libprotobuf)
+
----------------
sorry, what I meant by "less weird names" was can we call these libraries `grpc++` instead of `gRPC::grpc++` and `protobuf` instead of `protobuf::libprotobuf`?
Those thare the names that the libraries are installed as on my system at least...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77794/new/

https://reviews.llvm.org/D77794





More information about the cfe-commits mailing list