[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`
Ehud Katz via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 14 05:50:03 PDT 2020
ekatz updated this revision to Diff 257299.
ekatz added a comment.
Herald added a subscriber: jfb.
Added test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78098/new/
https://reviews.llvm.org/D78098
Files:
clang/lib/CodeGen/CGExprAgg.cpp
clang/test/CodeGen/atomic-struct-bug.cpp
Index: clang/test/CodeGen/atomic-struct-bug.cpp
===================================================================
--- /dev/null
+++ clang/test/CodeGen/atomic-struct-bug.cpp
@@ -0,0 +1,19 @@
+// RUN: %clang_cc1 -emit-llvm %s -o - | FileCheck %s
+// PR45476
+
+// This test used to get into an infinite loop,
+// which, in turn, caused clang to never finish execution.
+
+struct s3 {
+ char a, b, c;
+};
+
+_Atomic struct s3 a;
+
+extern "C" void foo() {
+ // CHECK-LABEL: @foo
+ // CHECK: store atomic i32
+
+ a = s3{1, 2, 3};
+}
+
Index: clang/lib/CodeGen/CGExprAgg.cpp
===================================================================
--- clang/lib/CodeGen/CGExprAgg.cpp
+++ clang/lib/CodeGen/CGExprAgg.cpp
@@ -678,16 +678,16 @@
/// Attempt to look through various unimportant expressions to find a
/// cast of the given kind.
static Expr *findPeephole(Expr *op, CastKind kind) {
- while (true) {
- op = op->IgnoreParens();
- if (CastExpr *castE = dyn_cast<CastExpr>(op)) {
- if (castE->getCastKind() == kind)
- return castE->getSubExpr();
- if (castE->getCastKind() == CK_NoOp)
- continue;
- }
- return nullptr;
+ while (CastExpr *castE = dyn_cast<CastExpr>(op->IgnoreParens())) {
+ if (castE->getCastKind() == kind)
+ return castE->getSubExpr();
+
+ if (castE->getCastKind() != CK_NoOp || castE == op)
+ break;
+
+ op = castE;
}
+ return nullptr;
}
void AggExprEmitter::VisitCastExpr(CastExpr *E) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78098.257299.patch
Type: text/x-patch
Size: 1478 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200414/df1427a0/attachment-0001.bin>
More information about the cfe-commits
mailing list