[PATCH] D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals.
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 13 20:38:10 PDT 2020
rjmccall added inline comments.
================
Comment at: clang/include/clang/Serialization/ASTBitCodes.h:1892
+ /// A FixedPointLiteral record
+ EXPR_FIXEDPOINT_LITERAL,
};
----------------
Thanks!
I'm sorry to be extremely picky about this, but:
- Please put the comment on the same line and just make it `// FixedPointLiteral`, like all of the other node-specific comments.
- I think a reformatting of the other comments would be welcome, but if you're going to do it, please do it in a separate commit, and please just indent all of the comments to a consistent column.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57226/new/
https://reviews.llvm.org/D57226
More information about the cfe-commits
mailing list