[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 13 15:15:36 PDT 2020


dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/unittests/Support/MemoryBufferTest.cpp:396
+
+  auto MBOrError = MemoryBuffer::getOpenFile(FD, TestPath, -1, false, true);
+  ASSERT_NO_ERROR(MBOrError.getError())
----------------
Maybe add named arguments in comments for the last three?  They're a bit inscrutable, and the whole point is to test `IsVolatile`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77772/new/

https://reviews.llvm.org/D77772





More information about the cfe-commits mailing list