[PATCH] D77592: [NFC}[CodeGen] Make VTable initialization a method of CGCXXABI

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 13 14:41:40 PDT 2020


rjmccall added a comment.

This is a global switch, right, not something that's mix-and-match between hierarchies or even between classes?  I think I would prefer that the ABI object just tell us the expected layout of a v-table entry (as an enum) rather than forcing a bunch of different callbacks.  Seems more composable, among other things.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77592/new/

https://reviews.llvm.org/D77592





More information about the cfe-commits mailing list