[PATCH] D78038: [clangd] WIP: fix several bugs relating to include insertion

[Sam McCall via Phabricator via cfe-commits]

sammccall created this revision.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.

This should probably be untangled into 3 separate patches, but
looking for feedback first on whether we want to do this at all.

a) store include-insertion information for main-file symbols that are

  not eligible for code completion indexing.

b) consider an #ifndef guard that's dangling at the end of the preamble

  to be a well-formed header guard (otherwise we never will)

c) load HeaderFileInfo for the preamble main-file even if the file-size

  mismatches


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78038

Files:
  clang-tools-extra/clangd/index/SymbolCollector.cpp
  clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp
  clang/lib/Lex/Lexer.cpp
  clang/lib/Serialization/ASTReader.cpp
  clang/lib/Serialization/ASTWriter.cpp
  llvm/include/llvm/Support/OnDiskHashTable.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78038.257019.patch
Type: text/x-patch
Size: 7457 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200413/176f900e/attachment-0001.bin>