[PATCH] D78019: HIP: Fix handling of denormal mode

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 13 10:12:17 PDT 2020


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: clang/test/Driver/cuda-flush-denormals-to-zero.cu:27
+// Test multiple offload archs with different defaults.
+// RUN: %clang -x hip -no-canonical-prefixes -### -target x86_64-linux-gnu -c -march=haswell --cuda-gpu-arch=gfx803 --cuda-gpu-arch=gfx900 -nocudainc -nogpulib %s 2>&1 | FileCheck -check-prefix=MIXED-DEFAULT-MODE %s
+// RUN: %clang -x hip -no-canonical-prefixes -### -target x86_64-linux-gnu -c -march=haswell -fcuda-flush-denormals-to-zero --cuda-gpu-arch=gfx803 --cuda-gpu-arch=gfx900 -nocudainc -nogpulib %s 2>&1 | FileCheck -check-prefix=FTZX2 %s
----------------
yaxunl wrote:
> this will result in multiple clang -cc1 commands, each one corresponding to an arch. You need to check each arch.
Since the flag is not printed for the default case, having a second arch check line would interfere with the -NOT check, as there is no CHECK-SAME-NOT


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78019/new/

https://reviews.llvm.org/D78019





More information about the cfe-commits mailing list