[PATCH] D77923: OpenCL: Fix some missing predefined macros

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 13 08:34:34 PDT 2020


arsenm added a comment.

In D77923#1976497 <https://reviews.llvm.org/D77923#1976497>, @jvesely wrote:

> OPENCL_VERSION is something that should be really set by the opencl driver rather than the compiler.
>  coarse-grained SVM can be done without FEATURE_FLAT_ADDRESS_SPACE, so those gpus can get over 1.2, while the compiler can be used in an implementation that doesn't go above 1.2 even for gfx700+


The offline compiler needs to be perfectly usable, with no driver/runtime dependencies. Any information needed from the driver should be captured by the target triple/OS type. We would invent a new OS type if there was such a need


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77923/new/

https://reviews.llvm.org/D77923





More information about the cfe-commits mailing list