[PATCH] D76496: [clang-tidy] StringFindStartswith should ignore 3-arg find()

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 12 04:15:35 PDT 2020


njames93 added a comment.

In D76496#1949851 <https://reviews.llvm.org/D76496#1949851>, @niko wrote:

> Correct me if I'm wrong, but that seems to be in violation of IWYU? Maybe I'm misreading this, or is the idea that higher-lever tooling (e.g. IWYU fixer) is supposed to address that?


It is but it sort of gets a pass as the absl/strings/match.h has to include it. 
Similar to how if you `#include <vector>`, you wouldn't then `#include <initializer_list>` so you could construct a `std::vector` using a `std::initializer_list`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76496/new/

https://reviews.llvm.org/D76496





More information about the cfe-commits mailing list