[PATCH] D77938: [clangd] Extend YAML Serialization

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 11 08:31:41 PDT 2020


sammccall added a comment.

Thanks for doing this!



================
Comment at: clang-tools-extra/clangd/unittests/YAMLTests.cpp:1
+//===-- YAMLTests.cpp - YAML container unit tests -------------------------===//
+//
----------------
Ack, sorry for not mentioning this in the previous review.
The YAML stuff is tested mixed together with the binary format stuff in SerializationTests.cpp.
Is it possible to extend the YAML literal in that file with a synthetic Source and Cmd entry, and test it in a similar way?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77938/new/

https://reviews.llvm.org/D77938





More information about the cfe-commits mailing list