[PATCH] D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals.

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

Some minor requests, but otherwise this LGTM.



================
Comment at: include/clang/Serialization/ASTBitCodes.h:1637
+      /// A FixedPointLiteral record.
+      EXPR_FIXEDPOINT_LITERAL,
+
----------------
rjmccall wrote:
> ebevhan wrote:
> > I'm unsure if this is the right location for a new code. This will bump down all the other codes below this and cause any older file to not be read correctly.
> > 
> > Should the file format version number be bumped up?
> IIRC the real file format version for this is based on the exact revision of the compiler and there is no pretense of serialized ASTs being sharable between compilers.  I don't think we've ever bumped the version number for incompatible changes like this.
But really you should add the enumerator to the end of the list.


================
Comment at: test/PCH/fixed-point-literal.h:1
+// Header for PCH test fixed-point-literal.c
+
----------------
Inputs like this generally go into the `Inputs` directory. 


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57226/new/

https://reviews.llvm.org/D57226