[PATCH] D77592: [NFC}[CodeGen] Make VTable initialization a method of CGCXXABI
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 10 18:19:46 PDT 2020
rjmccall added a comment.
This is a weird point to allow further ABI customization of. I understand why you want to customize this, but I wonder if it's actually worthwhile to make a `virtual` function for it vs. just checking some sort of flag in the builder. Isn't there quite a lot of structure you're going to have to duplicate just to call `addRelativeAddress` at the leaves?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77592/new/
https://reviews.llvm.org/D77592
More information about the cfe-commits
mailing list