[PATCH] D73188: [AST] Improve overflow diagnostics for fixed-point constant evaluation.
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 10 18:19:45 PDT 2020
rjmccall accepted this revision.
rjmccall added a comment.
LGTM. I'm somewhat surprised that this is the implementation design for integer overflow diagnostics, but since it is, I see no reason not to adopt it for fixed-point as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73188/new/
https://reviews.llvm.org/D73188
More information about the cfe-commits
mailing list