[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 10 09:06:25 PDT 2020


steakhal added a comment.

It took me some time to understand what you were doing.
Probably a bit ASCII-art would have had help (eg. about the wrapping behavior).

By the same token, I wouldn't mind more tests, especially exercising the implemented behavior.
Probably `unit-tests` would fit better than `lit-tests` for this purpose.
Eg. showing that if the `RangeSet`  includes the `MIN`, then the negated `RangeSet` also includes that.
And the negated RangeSet really unites consecutive ranges.

Please note that **I'm not a math expert** and I haven't spent much time working with `RangeSets`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77802/new/

https://reviews.llvm.org/D77802





More information about the cfe-commits mailing list