[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.
Mehdi AMINI via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 9 23:57:46 PDT 2020
mehdi_amini added inline comments.
================
Comment at: llvm/include/llvm/Support/GenericDomTree.h:32
#include "llvm/ADT/SmallVector.h"
+#include "llvm/IR/CFGDiff.h"
#include "llvm/Support/CFGUpdate.h"
----------------
This looks like a layering violation to me here: I wouldn't expect a generic utility in Support to introduce a dependency on IR.
I speculatively reverted in https://github.com/llvm/llvm-project/commit/57d2d48399b63c0ef1dda490fdaf28efbb80c2c0 while we can figure it out.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77341/new/
https://reviews.llvm.org/D77341
More information about the cfe-commits
mailing list