[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews
Johannes Doerfert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 9 21:13:18 PDT 2020
jdoerfert added a comment.
In D77683#1970826 <https://reviews.llvm.org/D77683#1970826>, @mehdi_amini wrote:
> I am still not sure what "if someone has asked for extra review of a specific area" refers to?
As said earlier
>> If I understand this correctly, this is meant to cover situations where reviewers are active in an area and indicated an interest in reviewing basically everything.
>
> Pretty much, yes.
this should mean that, if requested, all non-trivial patches should go through review. The current wording is very lenient, especially wrt. code owners.
While most people I talked to don't see owners as special per se (but just assume they have more responsibility), this paragraph says they have special rights.
Given the murky ways owners are "selected", I think we should have a well defined way to limit these rights without revoking the status.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77683/new/
https://reviews.llvm.org/D77683
More information about the cfe-commits
mailing list