[PATCH] D77845: [analyzer][CallAndMessage][NFC] Change old callbacks to rely on CallEvent

[Kristóf Umann via Phabricator via cfe-commits]

Szelethus created this revision.
Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, balazske, martong, rnkovacs, dcoughlin.
Szelethus added a project: clang.
Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity.
Szelethus added a parent revision: D75430: [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker.
Szelethus added a child revision: D77846: [analyzer][CallAndMessage][NFC] Split up checkPreCall.

The following series of patches has something similar in mind with D77474 <https://reviews.llvm.org/D77474>, with the same goal to finally end incorrect checker names for good. Despite CallAndMessage not suffering from this particular issue, it //is// a dependency for many other checkers, which is problematic, because we don't really want dependencies to also emit diagnostics (reasoning for this is also more detailed in D77474 <https://reviews.llvm.org/D77474>).

CallAndMessage also has another problem, namely that it is responsible for a lot of reports. You'll soon learn that this isn't really easy to solve for compatibility reasons, but that is the topic of followup patches.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77845

Files:
  clang/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp
  clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77845.256461.patch
Type: text/x-patch
Size: 9088 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200410/27d4ce1e/attachment-0001.bin>