[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

Thu Apr 9 16:02:25 PDT 2020

sthibaul marked 2 inline comments as done.
sthibaul added a comment.

In D73845#1971282 <https://reviews.llvm.org/D73845#1971282>, @MaskRay wrote:

> Moving functions from Linux.cpp to Gnu.cpp is definitely appropriate. Have you made any adjustment?

No, it's really pure code move (and the requested codestyle fixes)

================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2694
+
+void Generic_GCC::AddGCCMultilibPaths(const Driver &D,
+                                      const std::string &SysRoot,
----------------
phosek wrote:
> The class already has `GCC` in the name, so there's no need to repeat `GCC` in the name of the method, i.e. this can be just `Generic_GCC::AddMultilibPaths`. The same for other new methods.
Alright, fixing so

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73845/new/

https://reviews.llvm.org/D73845