[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 9 15:50:02 PDT 2020


sammccall added a comment.

Oops, hit enter too soon.

Well done getting this to work, will patch it and try out locally.



================
Comment at: clang-tools-extra/clangd/index/shared/SharedIndexServer.cpp:43
+// FIXME(kbobyrev): This is copied
+std::vector<SymbolID> getSymbolIDsFromIndex(llvm::StringRef QualifiedName,
+                                            const SymbolIndex *Index) {
----------------
For a prototype, I wouldn't bother doing anything fancy at all.
Either just do a fuzzyfind, or just do a lookup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77794/new/

https://reviews.llvm.org/D77794





More information about the cfe-commits mailing list