[PATCH] D77701: [Sema] refactor static functions into private methods NFC

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 9 12:52:53 PDT 2020


dblaikie added a comment.

Yeah, if these were already member-function static, I'd agree it was a code smell - but function-scope static functions that take "this" as the first parameter don't seem like a bad thing to me - it reduces the header surface area/dependence.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77701/new/

https://reviews.llvm.org/D77701





More information about the cfe-commits mailing list