[PATCH] D77391: [analyzer][AnalysisOrder] Display the CallEvent type for preCall/postCall

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 9 07:35:56 PDT 2020


Szelethus marked 2 inline comments as done.
Szelethus added inline comments.


================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:202
   virtual Kind getKind() const = 0;
+  virtual StringRef getKindAsString() const = 0;
 
----------------
NoQ wrote:
> Maybe make a `static StringRef getKindAsString(Kind);` in the base class and defer to it instead so that they all were in one place near the enum itself?
> 
> (i'm not sure it's actually better)
Well, each of these kinds are tied to a `CallEvent` class, so this made sense when I wrote it. I think these approaches are equivalent, so I'll stick with this one if you don't mind :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77391/new/

https://reviews.llvm.org/D77391





More information about the cfe-commits mailing list